Ignore loaders and absolute paths #36

amasad · 2020-04-30T23:53:09Z

Webpack allows users to add ! to load arbitrary files and this should be ignored by upm.
More generally I ported the code from here

upm/resources/nodejs/bare-imports.js

Lines 160 to 177 in c9627d2

    
           if (module.indexOf("!") != -1) { 
        
             continue; 
        
           } 
        
           // Prevent our code from crashing. 
        
           if (module === "") { 
        
             continue; 
        
           } 
        
           // Skip local modules. 
        
           if (module[0] === ".") { 
        
             continue; 
        
           } 
        
           // Skip absolute modules. 
        
           if (module[0] === "/") { 
        
             continue; 
        
           }

dan-stowell

If it's good enough for bare-imports.js, it's good enough for its successor!

amasad · 2020-05-01T01:09:05Z

Thanks!

Ignore script loaders and absolute paths

4e3d8c1

amasad requested review from dan-stowell and turbio April 30, 2020 23:53

dan-stowell approved these changes May 1, 2020

View reviewed changes

amasad merged commit d2c48ca into master May 1, 2020

amasad deleted the am-fix-script branch May 1, 2020 01:09

blast-hardcheese added the enhancement New feature or request label Dec 19, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ignore loaders and absolute paths #36

Ignore loaders and absolute paths #36

amasad commented Apr 30, 2020

dan-stowell left a comment

amasad commented May 1, 2020

	if (module.indexOf("!") != -1) {
	continue;
	}

	// Prevent our code from crashing.
	if (module === "") {
	continue;
	}

	// Skip local modules.
	if (module[0] === ".") {
	continue;
	}

	// Skip absolute modules.
	if (module[0] === "/") {
	continue;
	}

Ignore loaders and absolute paths #36

Ignore loaders and absolute paths #36

Conversation

amasad commented Apr 30, 2020

dan-stowell left a comment

Choose a reason for hiding this comment

amasad commented May 1, 2020